vert-x / mod-lang-groovy

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-groovy
Other
16 stars 15 forks source link

Does not work the random access writes. #68

Closed rodrigoSaladoAnaya closed 10 years ago

rodrigoSaladoAnaya commented 10 years ago

The example [http://vertx.io/core_manual_groovy.html#random-access-writes] does not work, always leaves an empty file.

The problem is her [https://github.com/vert-x/mod-lang-groovy/blob/master/src/main/groovy/org/vertx/groovy/core/file/AsyncFile.groovy#L73]

It is sending a 'org.vertx.groovy.core.buffer.Buffer' instead of a 'org.vertx.java.core.buffer.Buffer' with a [Buffer].toJavaBuffer()

rodrigoSaladoAnaya commented 10 years ago

I have signed the Eclipse CLA.

LostInBrittany commented 10 years ago

Thnaks for finding it! Do you want to submit the pull request to correct it or I do it?

On Fri, Apr 18, 2014 at 10:53 AM, Rodrigo Salado Anaya < notifications@github.com> wrote:

I have signed the Eclipse CLA.

— Reply to this email directly or view it on GitHubhttps://github.com/vert-x/mod-lang-groovy/issues/68#issuecomment-40796096 .

LostInBrittany commented 10 years ago

Doing the pullo request now, thanks again !

LostInBrittany commented 10 years ago

It should work now, sending [Buffer].toJavaBuffer() parameters

rodrigoSaladoAnaya commented 10 years ago

Thanks and regards. : )

LostInBrittany commented 10 years ago

I didn't see any pull request :( I've submitted a patch according to your suggestion, the problem should be corrected now. Thanks again for your input!!