search

vert-x / mod-lang-groovy

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-groovy
Other
16 stars 15 forks source link

Issue #73 and Source encoding problem #74

Closed LostInBrittany closed 10 years ago

LostInBrittany commented 10 years ago

It seems the problem was a ISO1252 configuration in src/test/resources/ files.There the conf set groovy.source.encoding to ISO1252 in compilerConfiguration.groovy and compilerConfiguration.properties. Source files are in UTF-8, so I put groovy.source.encoding to UTF-8 (and changed src/test/groovy_scripts/platform/impl/testGroovyVerticleFactory.groovy to comply) and everything worked (besides a silly broken test I had added). I'm not sure of why it worked before, and why it didn't work anymore. Groovy 2.3.3 seems stricter than old goovy versions, when I migrated mod-lang-groovy to Groovy 2.3.3 last week, I had to make some changes to comply. So maybe it is. If you have another explanation, I'd love to hear it :)

Going to push the pull request now...

millross commented 10 years ago

Yep, all good now (tested on Ubuntu and OS X). Will get cracking on my PR as soon as I get a free moment. Thanks for solving it so quickly!