Closed millross closed 10 years ago
LostInBrittany
commented
10 years ago Sorry for the long delay, I hadn't seen your pull request, I've just noticed it :-(
When testing your code, I get some errors: I'm going to look at it this week, to find why. If you have an idea, tell me :)
Update
Problem found with test version, correcting and re-testing now, the pull request will be validated quickly
millross
commented
10 years ago There was no rush on the PR, I was coding against a local build in the meantime (hobby project anyway!) Thanks for merging it - my code shouldn’t have had that error since the point of the PR was to add the netSocket property - did I screw up the PR? If so, I’m really sorry.
Cheers,
Jez
LostInBrittany
commented
10 years ago You didn't screw up anything, I did some changes between the moment your sent the pull request and yesterday, so minor changes were required.
Thanks again for your help !
Regards,
Horacio
On Mon, Sep 8, 2014 at 7:09 PM, millross notifications@github.com wrote:
There was no rush on the PR, I was coding against a local build in the meantime (hobby project anyway!) Thanks for merging it - my code shouldn’t have had that error since the point of the PR was to add the netSocket property - did I screw up the PR? If so, I’m really sorry.
Cheers,
Jez
— Reply to this email directly or view it on GitHub https://github.com/vert-x/mod-lang-groovy/pull/75#issuecomment-54853097.
Make groovy HttpClientResponse and DefaultHttpClientResponse classes consistent with their core Java versions by exposing the netSocket member.
While the use-cases for needing visibility of this member are limited, I've run into one when working with the Twitter streaming API (want to be able to kill the response from the client side at will when I've got all the data I need from the stream - closing the netsocket connection would appear to be the least bad approach to this).
This includes a test (ported from the Java codebase) for the netSocket member.