search

vert-x / mod-lang-groovy

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-groovy
Other
16 stars 15 forks source link

JsonArray's should be converted back to a List on the receiving side. #77

Closed nscavell closed 10 years ago

nscavell commented 10 years ago

So I noticed that we convert from List to JsonArray when sending, but back on the receiving side we do not. Surely if I send a List over the EventBus I should get a List back ?

However it should be noted this could possibly break existing code if they do indeed expect a JsonArray on the receiving side.

This is more in line with how we treat JsonObject -> Map as well.

LostInBrittany commented 10 years ago

I agree we should receive a List back, and I agree it's more coherent, as we do the same thing with maps.

I'm afraid we can be breaking some code here, but I cannot find a good reason to keep things as they are.

LostInBrittany commented 10 years ago

And thanks for your pull request!