search

vert-x / mod-lang-scala

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-scala
Apache License 2.0
77 stars 35 forks source link

Minor API adjustments for 1.0.0 #141

Closed galderz closed 10 years ago

Narigo commented 10 years ago

Definitely better than having Iterable[String] or Java Lists!

galderz commented 10 years ago

@Narigo Added some tests.

Narigo commented 10 years ago

@galderz Added some notes. Especially the () lines are... strange. Are they really needed? If so, do we have a mistake in our type system here?

galderz commented 10 years ago

@Narigo I'm pushing this. The () is needed because the function definition in the test returns unit. Since all our methods return fluent types, I couldn't find a way to do when functions are defined separately. If functions are embedded, as in other tests, I don't think it's a problem, but I didn't dig further.

galderz commented 10 years ago

Feel free to ping me if you have any other ideas