search

vert-x / mod-lang-scala

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-lang-scala
Apache License 2.0
77 stars 35 forks source link

gh-155 Fix HTTP CONNECT test expectations and adjust scaladoc #157

Closed galderz closed 10 years ago

Narigo commented 10 years ago

Refactoring looks fine and you're right about the expectations. I don't think I've ever really used something else than GET, POST, PUT and DELETE in one of the scripts I've written...

I've added some notes about the test itself, which you might want to look into.

Shall we add tests that none of the other methods can get the netSocket() or is that a bad idea?

galderz commented 10 years ago

I've added some notes about the test itself, which you might want to look into.

What notes? Where?

galderz commented 10 years ago

Shall we add tests that none of the other methods can get the netSocket() or is that a bad idea?

I think it's Ok with what we have but if you have the chance to add more tests, feel free.

galderz commented 10 years ago

Updated with the move of received buffer initialisation.

galderz commented 10 years ago

Integrated