search

vert-x / vertx-maven

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-maven-starter
Other
22 stars 31 forks source link

Fixed broken build fatJar maven goal when vertx maven project is a subproject of other project #21

Closed kmakowski closed 10 years ago

johnoliver commented 10 years ago

+1 on this bug fix, can confirm this is an issue and this fixes it, could be improved with:

project.getBasedir().getAbsolutePath() + File.separator + "target"

But other than that works well

kmakowski commented 10 years ago

thanks John. Also "target" should not be hardcoded.

johnoliver commented 10 years ago

This is true, add the parameter to the mojo ${project.build.directory}

purplefox commented 10 years ago

Thanks. kmakowski - have you signed the Eclipse CLA?

sjonnalagadda commented 10 years ago

I have signed CLA and here is the pull request. https://github.com/vert-x/vertx-maven/pull/25

kmakowski commented 10 years ago

Yes, I have signed the Eclipse CLA.