VertxPullInDepsMojo if not event.succeeded() it should cause build to fail, not just be logged

vert-x / vertx-maven

Vert.x 2.x is deprecated - use instead

https://github.com/vert-x3/vertx-maven-starter

Other

22 stars 31 forks source link

VertxPullInDepsMojo if not event.succeeded() it should cause build to fail, not just be logged #39

Closed vorburger closed 3 years ago

vorburger commented 9 years ago

how about this?

The other Mojo's have the same problem BTW - consider changing them accordingly, or better something in BaseVertxMojo to handle failure? Want another PR?

PS: Re. Eclipse CLA, I'm an Eclipse commiter, so you're cool. Let me know if you need.. some ID (what?).

vorburger commented 3 years ago

Whoa! I'm cleaning up many of my very old open PRs, from MANY years ago.. closing!