search

vert-x / vertx-maven

Vert.x 2.x is deprecated - use instead
https://github.com/vert-x3/vertx-maven-starter
Other
22 stars 31 forks source link

systemPropertyVariables configuration option #8

Open msiedlarek opened 11 years ago

msiedlarek commented 11 years ago

This patch adds a systemPropertyVariables configuration option, which allows you to define system properties to be set when running a module.

This is particularly useful for setting the org.vertx.logger-delegate-factory-class-name property (my use case).

The option name and concept comes from the Apache Maven Surefire plugin (https://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html).

purplefox commented 11 years ago

Have you signed the Eclipse CLA? Also, can you provide the email address you signed it with?

msiedlarek commented 11 years ago

Well, I tried to... https://bugs.eclipse.org/bugs/show_bug.cgi?id=412009 . I'll let you know as soon as it's done.

purplefox commented 11 years ago

Weird - I have no problem signing it, and lots of other people have without problem.

Can you try a different browser?

msiedlarek commented 11 years ago

Tried Safari 6.0.5, Chrome 27 and Firefox 21 with same result.

msiedlarek commented 11 years ago

The CLA bug have been fixed and I've signed mine. You are free to merge my humble patch.

adamdyga commented 10 years ago

Simple but useful feature, will it be merged?