vert-x3 / issues

Apache License 2.0
36 stars 7 forks source link

RxJava 1 bindings for new modules are no longer generated #596

Closed InfoSec812 closed 2 years ago

InfoSec812 commented 2 years ago

Version

4.2.3

Context

When I add the io.vertx:vertx-rx-java:4.2.3 dependency, I expect that there should be a class something like:

io.vertx.rxjava.ext.web.openapi.RouterBuilder which can take io.vertx.rxjava.core.Vertx as an argument to it's 'rxCreate` method.

Do you have a reproducer?

No

Steps to reproduce

  1. Add the vertx-rx-java and vertx-web-openapi dependencies to a project
  2. In a Verticle, attempt to use RouterBuilder.rxCreate(vertx, "/path/to/openapi.yaml");

Extra

tsegismont commented 2 years ago

It's seems only the RxJava 2 and 3 bindings are generated: https://github.com/vert-x3/vertx-rx/search?q=vertx-web-openapi

tsegismont commented 2 years ago

Actually, this is a duplicate of https://github.com/vert-x3/vertx-rx/issues/256

Please upgrade to RxJava 3 (RxJava 1 nor 2 are not supported anymore)

InfoSec812 commented 2 years ago

Ahhhh! Then I highly recommend a big noticeable message on the documentation pages first them.

Deven

On Mon, Jan 31, 2022, 4:56 AM Thomas Segismont @.***> wrote:

Actually, this is a duplicate of vert-x3/vertx-rx#256 https://github.com/vert-x3/vertx-rx/issues/256

Please upgrade to RxJava 3 (RxJava 1 nor 2 are not supported anymore)

— Reply to this email directly, view it on GitHub https://github.com/vert-x3/issues/issues/596#issuecomment-1025558313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYK27TWDLPIV6AZJAHJPTUYZMGFANCNFSM5NEPLQ6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

tsegismont commented 2 years ago

On this one? https://vertx.io/docs/vertx-rx/java/

Message ID: @.***>

InfoSec812 commented 2 years ago

I see no notice there... image

tsegismont commented 2 years ago

I meant: what do you think about adding a notice on vertx-rxjava 1 doc ?

Message ID: @.***>

InfoSec812 commented 2 years ago

Yes, I think that makes a great deal of sense if it truly is end-of-life.