search

vert-x3 / vertx-4-migration-guide

Migration to Vert.x 4 guide
https://vert-x3.github.io/vertx-4-migration-guide/index.html
20 stars 16 forks source link

Rename asciidoc attributes starting with a number #31

Closed vietj closed 3 years ago

vietj commented 3 years ago

Currently there are two Asciidoc attributes starting with a number that cannot be substituted when we build the HTML output: {4} and {3x}.

We can rename them to {v4} and {v3x}

vietj commented 3 years ago

@sangeetaraghu is that fine with you ?

sangeetaraghu commented 3 years ago

@vietj yes that sounds ok. No problem. Do you want me to search-replace and push the files maybe later today?

vietj commented 3 years ago

yes please

On Tue, Dec 1, 2020 at 2:44 PM Sangeeta Raghu-Punnadi < notifications@github.com> wrote:

@vietj https://github.com/vietj yes that sounds ok. No problem. Do you want me to search-replace and push the files maybe later today?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-4-migration-guide/issues/31#issuecomment-736560019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCQ2XLSTST35TJ7K4LDSSTXLPANCNFSM4UJBMWYA .