search

vert-x3 / vertx-amqp-client

An AMQP client for Vert.x
Apache License 2.0
17 stars 18 forks source link

ensure transport is disconnected on connection close, and respond to remote close frame #44

Closed gemmellr closed 4 years ago

gemmellr commented 4 years ago

The client doesn't disconnect the TCP connection on closure after receiving an AMQP Close frame, so if the other side doesn't either it will remain open. This is true of local and remote initiated closures. For remote closures, the client should additionally 'respond' first by sending its own Close frame as the protocol is symmetric and peers may or may not wait for the matched frame.

cescoffier commented 4 years ago

Thanks!

cescoffier commented 4 years ago

This should be backported in the 3.9 branch.

gemmellr commented 4 years ago

Backported in https://github.com/vert-x3/vertx-amqp-client/commit/9359789f59091ed4a186d58b0007df4bb6c97d77

cescoffier commented 4 years ago

Thanks @gemmellr !