search

vert-x3 / vertx-amqp-client

An AMQP client for Vert.x
Apache License 2.0
17 stars 18 forks source link

finish off test improvements #48

Closed gemmellr closed 4 years ago

gemmellr commented 4 years ago

Final set of changes to use a test server to more closely verify the client behaviours of interest, rather than a full broker.

Follows on from #45, #46, #47. Knocks a final 15+ seconds off a build+test, which now only takes a little more than that in total.

cescoffier commented 4 years ago

Oh no... you removed test containers :-D !

Thanks! That's great!

gemmellr commented 4 years ago

Yep, it shall be mis...mm, nope :)

Another side benefit I've failed to note explicitly so far is that in not using the broker the tests will no longer start timing out if the brokers disk usage based flow control should kick in, which happens at 90% usage by default (but is configurable). I saw some tests on repeat that I'd guess may be because of being affected by that in CI, since I actually saw it happen locally.

gemmellr commented 4 years ago

Cherry picked to 3.9 branch in commits: cce0af29aabc115aa27a8a71b895845e05320550, 5247e7429f45493d01ca3f1f3377ebf65c7ef75c, 5a320f427b14bc9ddfcce822f0115c1e14303151, and 067eb980c4aff76b380d8ff5e10d836192c5d162