search

vert-x3 / vertx-circuit-breaker

A circuit breaker for Vert.x
Apache License 2.0
63 stars 32 forks source link

Deadlock in vertx event loop thread in class HystrixMetricEventStream #54

Closed shubhhampagui closed 2 years ago

shubhhampagui commented 2 years ago

Questions

Getting a deadlock in vertx event loop thread in class HystrixMetricEventStream

Version

3.9.2

Context

Following is the stack trace of the deadlock.

Found one Java-level deadlock:

"vert.x-eventloop-thread-33": waiting to lock monitor 0x00007fb2dc0ab5b8 (object 0x00000005decc1d00, a java.util.Collections$SynchronizedList), which is held by "vert.x-eventloop-thread-32" "vert.x-eventloop-thread-32": waiting to lock monitor 0x00007fb5e40175c8 (object 0x00000006217cd9c8, a io.vertx.core.http.impl.Http1xServerConnection), which is held by "vert.x-eventloop-thread-33"

Java stack information for the threads listed above:

"vert.x-eventloop-thread-33": at java.util.Collections$SynchronizedCollection.remove(Collections.java:2038)

`"vert.x-eventloop-thread-32": at io.vertx.core.http.impl.HttpServerResponseImpl.write(HttpServerResponseImpl.java:677)

vietj commented 2 years ago

I think the exception handler should not be called within the synchronized block in ConnectionBase

vietj commented 2 years ago

see https://github.com/eclipse-vertx/vert.x/pull/4276

shubhhampagui commented 2 years ago

@vietj We are upgrading to vertx version 4.2.0. Is this issue fixed in that version?

vietj commented 2 years ago

no it should be 4.2.5

On Mon, Feb 21, 2022 at 3:47 PM shubhhampagui @.***> wrote:

@vietj https://github.com/vietj We are upgrading to vertx version 4.2.0. Is this issue fixed in that version?

— Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-circuit-breaker/issues/54#issuecomment-1046955317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCRTGBHAR663ZHAX56TU4JGA5ANCNFSM5N7YMRDQ . You are receiving this because you were mentioned.Message ID: @.***>