vert-x3 / vertx-circuit-breaker

A circuit breaker for Vert.x
Apache License 2.0
63 stars 32 forks source link

Improvements #71

Closed Ladicek closed 1 year ago

Ladicek commented 1 year ago

Motivation:

The context is https://github.com/vert-x3/issues/issues/633, and this commit is a first step towards that goal. It does:

I have also started working on a Resilience4j howto, which shall be linked from the documentation here. In fact, I already have Vert.x wrappers for all Resilience4j fault tolerance patterns (bulkhead, circuit breaker, rate limiter, retry, time limiter -- I didn't include cache for obvious reasons), so we could possibly make into a full-fledged extension (and deprecate the Vert.x circuit breaker maybe?). That's for later, for sure.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

Ladicek commented 1 year ago

Added one more commit that mentions Resilience4j at the end of the documentation (where Hystrix usage used to be documented). The documentation is very brief, it mostly just points to the recently published how-to: https://how-to.vertx.io/resilience4j-howto/

tsegismont commented 1 year ago

I have also started working on a Resilience4j howto, which shall be linked from the documentation here. In fact, I already have Vert.x wrappers for all Resilience4j fault tolerance patterns (bulkhead, circuit breaker, rate limiter, retry, time limiter -- I didn't include cache for obvious reasons), so we could possibly make into a full-fledged extension (and deprecate the Vert.x circuit breaker maybe?). That's for later, for sure.

Another option would be a Reactiverse project for Resilience4j integration

Ladicek commented 1 year ago

That would make sense too, good point!

vietj commented 1 year ago

can you rebase this PR please @Ladicek ?

Ladicek commented 1 year ago

Rebased.

vietj commented 1 year ago

Thanks @Ladicek