[Issue-102] Added support of HTTP headers, timeout, followRedirects to Http Configuration store

vert-x3 / vertx-config

Vert.x Configuration Service

Apache License 2.0

54 stars 64 forks source link

Closed gaol closed 4 years ago

gaol commented 4 years ago

Fixes: #102

Using RequestOptions in HttpConfigStore so that it is possible to specify HTTP headers from the configuration.
Introduce headers in the configuration
Introduce timeout in the configuration
Introduce followRedirects in the configuration
Do not require the host in configuration, the defaultHost in the HttpClientOptions will take effect if no host specified in the configuration.

gaol commented 4 years ago

@cescoffier @vietj Would you please review? Thanks !

vietj commented 4 years ago

minor comment

gaol commented 4 years ago

@vietj Updated to filter out null values from headers.

gaol commented 4 years ago

I think it goes well, I will merge the PR if no other comments :)

gaol commented 4 years ago

OK, with the updated HttpClient API, I updated this as well to include timeout, followRedirects as well as the headers.

vietj commented 4 years ago

beside the lambda, it's good to merge

vietj commented 4 years ago

@gaol any issue you merge or fix needs a version to be set so it can be in the release notes

gaol commented 4 years ago

@vietj Got it. :)