search

vert-x3 / vertx-config

Vert.x Configuration Service
Apache License 2.0
54 stars 64 forks source link

cache configuration value must be boolean instead of string #123

Closed danielprinz closed 3 years ago

danielprinz commented 3 years ago

Motivation:

In the example a wrong value is provided. It should be boolean instead of string. Using the example as is results in the following exception: java.lang.ClassCastException: class java.lang.String cannot be cast to class java.lang.Boolean

The config store is fetching a boolean: https://github.com/vert-x3/vertx-config/blob/a572183cba302a2b7accf544c93b0855ff87e2d6/vertx-config/src/main/java/io/vertx/config/impl/spi/SystemPropertiesConfigStore.java#L44

This PR corrects the example.

vietj commented 3 years ago

thanks!