search

vert-x3 / vertx-config

Vert.x Configuration Service
Apache License 2.0
54 stars 64 forks source link

Add 'raw-data' flag to 'EnvVariableConfigStore'. #17

Closed bmcustodio closed 7 years ago

bmcustodio commented 7 years ago

As discussed in #16. Introduction of PowerMock is necessary because no environment variable suitable for testing is guaranteed to exist across different systems (apart from SHLVL which I'd rather not use).

@cescoffier does this sound OK to you?

bmcustodio commented 7 years ago

@cescoffier have you had any time to look into this? 🤔

bmcustodio commented 7 years ago

@cescoffier just amended the PR and updated the documentation.

cescoffier commented 7 years ago

@brunomcustodio Looks good. Did you sign the Eclipse CLA? (http://www.eclipse.org/legal/ECA.php).

bmcustodio commented 7 years ago

@cescoffier I did.

cescoffier commented 7 years ago

Thank you @brunomcustodio !