search

vert-x3 / vertx-config

Vert.x Configuration Service
Apache License 2.0
54 stars 64 forks source link

Add handling for private ssh key in Git configuration. #52 #53

Closed SINGS079 closed 6 years ago

SINGS079 commented 6 years ago

I was looking how to add the public key to the bare repo and could not figure out how to do that. Posted a question in Jgit forum https://www.eclipse.org/forums/index.php/t/1094930/ but that also didn't help. Can you show some pointers on how to write the test case for this scenario?

cescoffier commented 6 years ago

Good question. Did you test it against a private repo?

Also, did you signed the Eclipse CLA?

SINGS079 commented 6 years ago

Yes, I tested this against my private repo.

And I haven't signed the Eclipse CLA.

SINGS079 commented 6 years ago

I just signed the Eclipse CLA. Thanks.

cescoffier commented 6 years ago

Thanks!

SINGS079 commented 6 years ago

Thanks for accepting the pull request. Any help on how can we update the documentation?

cescoffier commented 6 years ago

@SINGS079 I realized you did update the asciidoc file. So it's fine.