vert-x3 / vertx-config

Vert.x Configuration Service
Apache License 2.0
54 stars 64 forks source link

Feature request: Support for cookies in HTTP Config Retriever #60

Open abhi19gupta opened 6 years ago

abhi19gupta commented 6 years ago

The HTTP configuration store used by the Config Retriever takes in just the host, port, and path (as mentioned here and supposedly other options mentioned here). This feature request is for adding an option to send cookies along with the HTTP request. In my case, I use cookies to send authentication token along with the HTTP request.

PS: I had raised the same feature request here as well.

cescoffier commented 6 years ago

The underlying WebClient does not support passing cookie.

eutkin commented 6 years ago

Hi all. Why can't I just pass this information to the header?

https://gist.github.com/eutkin/3a237416b48bf6f69e3b5e534268f8da

gaol commented 4 years ago

@eutkin There is a PR to support request headers in HTTP Config Retriever: https://github.com/vert-x3/vertx-config/pull/103, would you please check if it works for you? :)