search

vert-x3 / vertx-config

Vert.x Configuration Service
Apache License 2.0
54 stars 64 forks source link

CredentialProvider to be used in update() function of GitConfigStore #76

Closed SINGS079 closed 5 years ago

SINGS079 commented 5 years ago

This will fix the following issue - https://github.com/vert-x3/vertx-config/issues/67 With this the ConfigRetriever will be able to pull the repository successfully. (https://github.com/vert-x3/vertx-config/blob/c8e66fec319d0215161715642f4c90399b34c227/vertx-config-git/src/test/java/io/vertx/config/git/GitConfigStoreWithGithubTest.java#L98) Now this line will return success compared to error

Authentication is required but no CredentialsProvider has been registered

cescoffier commented 5 years ago

Thanks!