vert-x3 / vertx-consul-client

Vert.x Consul Client
Apache License 2.0
34 stars 23 forks source link

vertx-consul-client POM not valid with java 17.0.1+ #84

Open michalszynkiewicz opened 3 years ago

michalszynkiewicz commented 3 years ago

Version

4.1.5

Context

Building a maven project, with java 17.0.1 or newer, fails with compilation failures after:

[WARNING] The POM for io.vertx:vertx-consul-client:jar:4.1.5 is invalid, transitive dependencies (if any) will not be available: 1 problem was encountered while building the effective model for io.vertx:vertx-consul-client:4.1.5
[ERROR] Failed to determine activation for profile java-17 @ 

The problematic thing is:

    <profile>
      <id>java-17</id>
      <activation>
        <jdk>[17,*)</jdk>
      </activation>
      <properties>
        <maven.test.skip>true</maven.test.skip>
      </properties>
    </profile>

Commenting out the profile makes the build pass.

Do you have a reproducer?

The problem is visible in SmallRye Stork: https://github.com/smallrye/smallrye-stork/

Steps to reproduce

  1. git clone https://github.com/smallrye/smallrye-stork/
  2. mvn clean install

Extra

I see the CI build for this project fails now too with the same error

michalszynkiewicz commented 3 years ago

CC @cescoffier