search

vert-x3 / vertx-dependencies

Defines the versions of the Vert.x components of the Vert.x stack.
Apache License 2.0
12 stars 40 forks source link

Use GitHub setup-java action #187

Open sullis opened 3 months ago

sullis commented 3 months ago

Motivation

joschi/setup-jdk is obsolete. The action's repo was archived in December 2022

image

The project README recommends using actions/setup-java

image

Links

https://github.com/joschi/setup-jdk/blob/main/README.md

Modifications

replace joschi/setup-jdk with standard GitHub Actions actions/setup-java

Conformance

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

sullis commented 3 months ago

cc: @vietj

sullis commented 3 months ago

PTAL @vietj

sullis commented 3 months ago

ready for review

vietj commented 3 months ago

what does it bring ?

I would rather do that as part of the general maintenance of all of vertx github actions instead of just this one

sullis commented 3 months ago

what does it bring ?

joschi/setup-jdk has been deprecated since December 2022. It is no longer maintained.

Details here: https://github.com/joschi/setup-jdk/blob/main/README.md

actions/setup-java is the recommended replacement.

vietj commented 3 months ago

open an issue here https://github.com/vert-x3/vertx-parent

sullis commented 3 months ago

Issue is open

sullis commented 2 months ago

Ready for review