search

vert-x3 / vertx-eventbus-bridge-clients

Home for various EventBus Bridge clients
Other
65 stars 33 forks source link

This fixes #23 #45

Closed varunkudalkar closed 3 years ago

varunkudalkar commented 3 years ago

Added changes according to issue #23.

gaol commented 3 years ago

@varunkudalkar would you please sign Eclipse Contributor Agreement? thanks :)

varunkudalkar commented 3 years ago

@gaol, I signed Eclipse Contributor Agreement, please validate and merge.

gaol commented 3 years ago

@varunkudalkar thanks, would you please squash into one commit? I will merge it when it is done :)

gaol commented 3 years ago

@varunkudalkar looks like you need to rebase :)

varunkudalkar commented 3 years ago

@varunkudalkar looks like you need to rebase :)

@gaol nothing returned on rebase, What to do next?

gaol commented 3 years ago

@varunkudalkar I see 10 commits in this PR, and 26 files changed. I think you can try to do the following:

git checkout master
git pull
// it looks like you are using master as your work branch, I think using a different branch will save lots of troubles.
git rebase origin/master
// maybe update the commits
git push <Your Fork Repo Name> master

Are you in vertx discord or gitter? we can discuss directly if you want :)

gaol commented 3 years ago

@varunkudalkar thank you for the contribution, I cherry-picked your commit into a new PR #46. :) This will be closed as suppressed by #46