Support Vert.x 4.x - Githubissues

vert-x3 / vertx-eventbus-bridge-clients

Home for various EventBus Bridge clients

Other

65 stars 33 forks source link

Support Vert.x 4.x #52

Closed leotu closed 2 years ago

leotu commented 3 years ago

i,e. "4.1.2</vertx.version>"

Test codes:

io.vertx.eventbusclient.test.TcpBusTest.java compiled failed: vertx.eventBus().send(...) should change to vertx.eventBus().request(...)
io.vertx.eventbusclient.test.WebSocketBusTest compiled failed: .requestHandler(router::accept) should change to .requestHandler(router::handle)

Missing file: io.vertx.test.proxy.SocksProxy.java

gaol commented 3 years ago

We may need to create a branch of Java client for Vert.x 3 and move the master branch towards Vert.x 4.

Ako-Njang commented 2 years ago

I am an Outreachy applicant @gaol @pendula95 can this be assigned to me?

sherrif10 commented 2 years ago

hello @leotu am an outreachy applicant , can you assigne this to me ?.

sherrif10 commented 2 years ago

Hello @gaol @pmlopes , Incase this issue is ready for work , would love working on it.

gaol commented 2 years ago

sure, any contribution is welcome :)

gaol commented 2 years ago

@pmlopes I would like have a branch called java-vertx-3 for vertx 3.x users, WDYT? :)

pmlopes commented 2 years ago

@gaol I think it's a good idea as we're trying to get everyone to be on vertx 4.

Ako-Njang commented 2 years ago

Hi @gaol @pmlopes I have sent in a PR for this #63. With regards to point 2, the file io.vertx.test.proxy.SocksProxy.java is added automatically during test from the vertx-core dependency with test scope.