search

vert-x3 / vertx-grpc

gRPC for Vert.x
78 stars 49 forks source link

Added exception Handler for Many to Many stream #142

Closed 0x01F4 closed 10 months ago

0x01F4 commented 10 months ago

when io.vertx.grpc.stub.ClientCalls.manyToMany called if exception happens before returning the StreamObserverReadStream exception is lost.There is no way to register exceptionHandler before the call.We can register exceptionHandler only after StreamObserverReadStream return from manyToMany.

Fix for https://github.com/vert-x3/vertx-grpc/issues/141

0x01F4 commented 10 months ago

@vietj can you please have a look at this change?

0x01F4 commented 10 months ago

@tsegismont can you please have a look at this change? Is changes are still accepted to this repo?

tsegismont commented 10 months ago

This project is deprecated, only security and critical bug fixes should be merged

0x01F4 commented 10 months ago

@tsegismont we will plan to move to https://github.com/eclipse-vertx/vertx-grpc. But in the mean time this issue is blocking us, can this accepted as critical fix?

tsegismont commented 10 months ago

@giri-vsr can you please rebase your PR? There has been some fixes to the master branch. Thank you

0x01F4 commented 10 months ago

@giri-vsr can you please rebase your PR? There has been some fixes to the master branch. Thank you @tsegismont Rebased.

tsegismont commented 10 months ago

Thank you @giri-vsr !