search

vert-x3 / vertx-ignite

Apache License 2.0
34 stars 28 forks source link

Add support for vertx-like ssl options #106

Closed zyclonite closed 3 years ago

zyclonite commented 3 years ago

Motivation:

Unify eventbus and cluster manager ssl options. Allows usage of the same certificates for clustering vertx securely.

Flags old config options as deprecated and to be removed in version 4.1

zyclonite commented 3 years ago

@tsegismont what do you think? https://github.com/vert-x3/vertx-ignite/blob/4583739934a3f69d4d938d1c00b757c9103a7bf1/src/main/java/examples/Examples.java#L65-L96

vietj commented 3 years ago

can we merge this PR for 4.0.1 ?

zyclonite commented 3 years ago

if @tsegismont or you are fine with this approach, yes definitely

zyclonite commented 3 years ago

thank you for the quick feedback i updated the breaking changes wiki page and implemented your suggestions