Add a constructor that let the user to use a custom Ignite instance

vert-x3 / vertx-ignite

Apache License 2.0

35 stars 28 forks source link

Add a constructor that let the user to use a custom Ignite instance #45

Closed jan-zajic closed 6 years ago

jan-zajic commented 7 years ago

Creates cluster manager instance with given Ignite instance. Use this constructor in order to share ignite cluster created outside IgniteClusterManager. Do not shutdown the cluster if we are not the owner of the cluster.

agura commented 7 years ago

@jan-zajic I don't see any real reason for having custom node name. Could you please clarify your intention and use case?

guoyu511 commented 7 years ago

@agura I think the problem is that we need a more configurable api to custom the Ignite instance.

For example:

Set the Ignite in client or server mode.
Custom the cache to replication or partition mode.
Using on-heap or off-heap memory.
etc...

So maybe passing a predefined Ignite instance to the ClusterManager is the more flexible way.

agura commented 7 years ago

@guoyu511Hmmm... Makes sense in some aspects but isn't true for your examples:

Set the Ignite in client or server mode - client node doesn't make sense in terms of cluster manager. Your always can start client Ignite node and connect to the existing cluster.
Custom the cache to replication or partition mode - it can be controlled through Ignite XML configuration or IgniteConfiguration.
Using on-heap or off-heap memory - it can be controlled through Ignite XML configuration or IgniteConfiguration.

tipok commented 6 years ago

We face following issue which would be resolved by this PR:

We're using Ignite in persistence mode, in this mode Ignite needs to be activated manually by calling Ignite.active(true) otherwise it's throwing a Exception during the first access. If we would pass a activated ignite instance we would be good.

agura commented 6 years ago

@tipok In progress. Issue #53

agura commented 6 years ago

Closed due to #53 .