vert-x3 / vertx-ignite

Apache License 2.0
35 stars 28 forks source link

fix consistent clearing of internal cache entries during shutdown #96

Closed zyclonite closed 3 years ago

zyclonite commented 3 years ago

should fix #92 and #94

zyclonite commented 3 years ago

@tsegismont i honestly do not like the vertx.close() either... but isn't that triggering a graceful shutdown and stopping of all verticles anyway?

the reason for doing the stop is, that ignite stops the member node and so all tries to access the cache will fail from that point on (so there seems to be no reason to keep anything alive) this happens only on split-brain situations or when all the configured timeouts are passed (depends as well on the base topology)

tsegismont commented 3 years ago

@zyclonite I understand the logic behind this line. But I fear this would cause more problems than it solves.

Perhaps this could be made configurable?

zyclonite commented 3 years ago

@tsegismont sure i can do that

zyclonite commented 3 years ago

@tsegismont from my perspective this can be merged