search

vert-x3 / vertx-infinispan

Infinispan Cluster Manager for Vert.x
Apache License 2.0
14 stars 16 forks source link

feat: add maven profiles for Infinispan 14 #131

Closed pk-work closed 1 year ago

pk-work commented 1 year ago

the jakarta version is currently failing, because a required dependency doesn't exist. But after reaching out to the ISPN community they opened a ticket [1] for me. Hopefully this is solved before the 4.5 release.

[1] https://issues.redhat.com/browse/ISPN-15106

pk-work commented 1 year ago

I have added a separated test for ISPN-14 and ISPN-14-jakarta, because the jakarta test is always failing due to the missing dependency. With separated tests we can see if ISPN 14 passes the tests in general. As soon as the dependency is available, I will merge the two separated tests.

pk-work commented 1 year ago

Thanks for reviewing @tsegismont , I'm on PTO and back on Thursday/Friday, then I will work on your feedback. I'd like to have this as part of 4.4.5.

pk-work commented 1 year ago

@tsegismont I pushed a new version, can you review again? I think I worked on all your feedback.

pk-work commented 1 year ago

Ah I missed the documentation. I will add it now.

pk-work commented 1 year ago

@tsegismont I added docs to describe how to switch to ISPN version 14

pk-work commented 1 year ago

I checked the dependency trees and also added docs to Infinispan Web Session Store

tsegismont commented 1 year ago

@pk-work don't forget to update master branch (or file an issue with milestone 5.0.0)