vert-x3 / vertx-kafka-client

Reactive Kafka Client for Vert.x
Apache License 2.0
84 stars 82 forks source link

Kafka client producer async write change #134

Closed vietj closed 5 years ago

vietj commented 5 years ago

Currently the Kafka write overloaded method provides as async result the record metadata write(KafkaProducerRecord<K, V>, Handler<AsyncResult<RecordMetaData>>).

Vert.x WriteStream defines so far the write(KakfaProducerRecord<K,V>) method which gets overloaded with write(KafkaProducerRecord<K, V>, Handler<AsyncResult<Void>>) in 3.7.1 as part of an improvement for write streams.

We need to rename the current write(KafkaProducerRecord<K, V>, Handler<AsyncResult<RecordMetaData>>) to send(KafkaProducerRecord<K, V>, Handler<AsyncResult<RecordMetaData>>) and change the async result type of write to be void.