allow .subscribe(Pattern ...) in KafkaConsumer

vert-x3 / vertx-kafka-client

Reactive Kafka Client for Vert.x

Apache License 2.0

84 stars 82 forks source link

allow .subscribe(Pattern ...) in KafkaConsumer #156

Closed anthonyshull closed 1 year ago

anthonyshull commented 4 years ago

Moved from vertx-rxjava. Allow the KafkaConsumer.subscribe(Pattern pattern) signature to be used in rxjava2.

anthonyshull commented 4 years ago

I believe this can be done just by changing @GenIgnore to @GenIgnore(GenIgnore.PERMITTED_TYPE)? Are there published contribution guidelines?

ppatierno commented 4 years ago

@vietj any thoughts?

IRQs commented 4 years ago

Is there a technical reason why this functionality has been disabled in the generation of the reactive Kafka client?

okolawole-ebsco commented 5 months ago

It appears that KafkaConsumer.subscribe(Pattern pattern) is not available in vertx-rx-java3 version 4.5.4. Is there a reason this change wouldn't expose the method during code gen?