search

vert-x3 / vertx-kafka-client

Reactive Kafka Client for Vert.x
Apache License 2.0
84 stars 82 forks source link

Picking up work in PR #205 #218

Closed jhughes24816 closed 2 years ago

jhughes24816 commented 2 years ago

Motivation:

Add ACL functionality to vertx-kafka-client

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

jhughes24816 commented 2 years ago

@vietj @ppatierno Can I get a review on this please?

jhughes24816 commented 2 years ago

@vietj @ppatierno Can this get a review please?

jhughes24816 commented 2 years ago

@vietj @ppatierno I have resolved the merge conflicts introduced from the other PR please review :)

vietj commented 2 years ago

thanks, can you review this @ppatierno ?

ppatierno commented 2 years ago

@vietj I think there is a pending question for you in the comments, or?

jhughes24816 commented 2 years ago

@vietj @ppatierno It would be good to close this out soon. Let me know if you need anything from me, happy to fix/adjust/refactors as required. Thanks!

vietj commented 2 years ago

Can you investigate @GenIgnore(GenIgnore.PERMITTED_TYPES) to use kafka types ?

jhughes24816 commented 2 years ago

I have pushed a commit that replaces the vertx copies of kafka objects with imports of the kafka objects. I have not added this annotation to anything since it was on all the acl methods in the interface already. Let me know if I have missed anything.

jhughes24816 commented 2 years ago

@vietj @ppatierno Is there anything else left to be done here?

vietj commented 2 years ago

LGTM as well.

vietj commented 2 years ago

thanks for your contribution @jhughes24816