search

vert-x3 / vertx-kafka-client

Reactive Kafka Client for Vert.x
Apache License 2.0
84 stars 82 forks source link

Add missing properties #227

Closed jhughes24816 closed 2 years ago

jhughes24816 commented 2 years ago

Motivation:

From the work I previously committed (#217 and #218) I had overlooked adding a couple of properties that are part of the usual Kafka responses to the admin client calls being made here.

This work adds those properties.

@ppatierno @vietj Comments and adjustments welcome, thanks!

jhughes24816 commented 2 years ago

Glad it passed, just wanted to add this comment:

It seems the testCreatePartitionInTopicWithAssignment is a bit flaky as it sometimes passes/fails? Is there an issue open to address this?

vietj commented 2 years ago

@jhughes24816 feel free to open an issue for the flaky test, those are a pain

jhughes24816 commented 2 years ago

Hi there @ppatierno @vietj Please merge when convenient. Thanks