search

vert-x3 / vertx-kafka-client

Reactive Kafka Client for Vert.x
Apache License 2.0
84 stars 82 forks source link

Fixes an issue in close handler not forwarding the timeout #240

Closed aesteve closed 1 year ago

aesteve commented 1 year ago

Motivation:

As reported on Discord: https://discord.com/channels/751380286071242794/751398291874512967/1097519534753198150

There seems to be a bug of KafkaProducerWriteImpl not forwarding the timeout to the close handler.

I have been able to reproduce in the new added test (revert line 298 of KafkaProducerImpl and the test won't pass) and fix it.

aesteve commented 1 year ago

Not sure why the ECA fails, I revalidated it