search

vert-x3 / vertx-kafka-client

Reactive Kafka Client for Vert.x
Apache License 2.0
84 stars 82 forks source link

Upgrade the apache kafka-client version to 3.4.0 #246

Closed AnshulAngaria closed 1 year ago

AnshulAngaria commented 1 year ago

Describe the feature

Current latest vertx-kafka-client v4.4.1 uses apache kafka-client version 3.0.2 We need latest kafka-client version 3.4.0. Can we release this?

tsegismont commented 1 year ago

Is that possible @ppatierno ?

AnshulAngaria commented 1 year ago

@tsegismont I see this is already done https://github.com/vert-x3/vertx-kafka-client/pull/238. When is the due date for 4.4.2 release?

tsegismont commented 1 year ago

@AnshulAngaria #238 targets Vert.x 5, this has not been backported to 4.x (not sure it is feasible)

Thoughts @julianladisch ?

julianladisch commented 1 year ago

I agree to a back-port to 4.5.x.

I disagree to a back-port to 4.4.x because a Vert.x patch release should not bump kafka-client from 3.0.1 to 3.4.0 introducing many changes.

julianladisch commented 1 year ago

@AnshulAngaria Have you tried to manually upgrade kafka-client in your own code so that you don't need to wait for a Vert.x release?

AnshulAngaria commented 1 year ago

@julianladisch Yes I have manually updated the kafka-client, that has fixed my issue.

AnshulAngaria commented 1 year ago

@julianladisch Will manually upgrading kafka-client might introduce some breaking changes ?

ppatierno commented 1 year ago

I don't see problems to upgrade to kafka 3.4.0 even for a Vert.x 4.4.x patch release. But I see that the discussion moved forward and now it's targeted for Vert.x 5.

tsegismont commented 1 year ago

Thank you @ppatierno

tsegismont commented 1 year ago

And thanks @julianladisch for helping