search

vert-x3 / vertx-kafka-client

Reactive Kafka Client for Vert.x
Apache License 2.0
84 stars 82 forks source link

Fix KafkaClientOptions.toJson() so JsonObject includes config contents #247

Closed lawalib closed 1 year ago

lawalib commented 1 year ago

fix KafkaClientOptions.toJson() so the JsonObject includes the config contents

Motivation:

At present KafkaClientOptions.toJson() always returns an empty JsonObject, even if the config map is not empty. This PR fixes that, so that the returned JsonObject reflects what's in the config map.

vietj commented 1 year ago

can you signe the eclipse contributor agreement @lawalib ?

lawalib commented 1 year ago

Hello @vietj . I've signed the ECA.

vietj commented 1 year ago

thanks @lawalib can you backport this to the 4.x branch ?

lawalib commented 1 year ago

@vietj done - I've created PR #248 to port this change to the 4.x branch.