Groovy 2.5

[aaloise]

Apache Groovy 2.5 was recently released.

Consider to upgrade at the appropriate time.

Groovy 2.5 requires JDK8+ to build and JDK7 is the minimum version of the JRE that it supports.

[vietj]

I think one issue is that the groovy-all jar does not exist anymore

[vietj]

so we need to find the right dep to use

[aaloise]

Found the following post on Twitter:

@daniel_sun Since #groovylang 2.5.0, pls grab groovy-all dependency as follows:

gradle:

compile 'org.codehaus.groovy:groovy-all:x.y.z'

maven:

<groupId>org.codehaus.groovy</groupId>
<artifactId>groovy-all</artifactId>
<version>x.y.z</version>
<type>pom</type> <!-- the key difference -->

https://twitter.com/daniel_sun/status/1003474637697642496

[vietj]

can you make a PR for this project ?

On 7 Jun 2018, at 14:32, aaloise notifications@github.com wrote:

Found the following post on Twitter:

@daniel_sun Since #groovylang 2.5.0, pls grab groovy-all dependency as follows:

gradle:

compile 'org.codehaus.groovy:groovy-all:x.y.z'

maven:

org.codehaus.groovy groovy-all x.y.z pom

https://twitter.com/daniel_sun/status/1003474637697642496 https://twitter.com/daniel_sun/status/1003474637697642496 — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-lang-groovy/issues/57#issuecomment-395403685, or mute the thread https://github.com/notifications/unsubscribe-auth/AANxilWeMqq7_glAe2wdnw3wXD7SBIhIks5t6R1ygaJpZM4UdnJg.

[aaloise]

Done https://github.com/vert-x3/vertx-lang-groovy/issues/58

[aaloise]

And also #59 , in #58 I forgot to edit pom.xml of codegen

[vietj]

can you close them and make a single PR @aaloise ?

[aaloise]

Closed #58 and #59, also created #60 with both files changed

[aaloise]

Well, since #60 didn't work, I look around a little and found this at Grovvy install directions using Maven in the official site:

<groupId>org.codehaus.groovy</groupId>
<artifactId>groovy-all</artifactId>
<version>2.5.0</version>

http://groovy-lang.org/install.html#_maven_repository

Seems pretty much the same like it was with 2.4

[aaloise]

@vietj sorry to ask, but witch version of JDK was used to compile after #60 got merged?

[vietj]

java version "1.8.0_172"

[aaloise]

The compilation errors are because at compile time packages from Groovy aren't being found. Errors such as "package org.codehaus.groovy.ast does not exist" and "ScriptVerticle.java:[38,17] cannot find symbol symbol: class Script location: class io.vertx.lang.groovy.ScriptVerticle" are happening.

It's like Groovy dependency does not get downloaded or it is not present at compile phase. I don't know exactly what it is, but I suspect that something must be ajusted in pom.xml, but don't know what precisely.

Don't know much about Maven, so I got stuck on this one.