Support deploying/requiring from npm modules plus improvements in how as...

vert-x3 / vertx-lang-js

Nashorn JavaScript implementation for Vert.x

Apache License 2.0

35 stars 23 forks source link

Support deploying/requiring from npm modules plus improvements in how as... #8

Closed purplefox closed 9 years ago

purplefox commented 9 years ago

...ync start and stop is implemented

purplefox commented 9 years ago

@vietj can you review this please?

vietj commented 9 years ago

The usage of the previous require.js should be done and the file src/main/resources/vertx-js/util/require.js should be removed

vietj commented 9 years ago

In JSVerticleFactory the line engine.put("__verticle", this) does not seem to be used anymore and should probably be removed

vietj commented 9 years ago

Another question : I see this allow to load verticles from NPM, do we allow also to load NPM arbitrary NPM modules from JS code. If yes I think we should have a test loading an NPM module from a simple JS vert.x module.