search

vert-x3 / vertx-lang-kotlin

Vert.x for Kotlin
Apache License 2.0
296 stars 68 forks source link

Router DSL #151

Closed Tim-Britton closed 1 year ago

Tim-Britton commented 5 years ago

Hello All,

This pull request includes the Router DSL that I am working on. See #91

Any feedback is welcome!

Tim

Tim-Britton commented 5 years ago

@vietj As far as testing the DSL how would you like that to be done?

I would normally use mockk to perform the testing but I'm not sure if its okay to add a new dependency to the project.

okou19900722 commented 5 years ago

Directory src/main/kotlin will be removed by the clean task, https://github.com/vert-x3/vertx-lang-kotlin/blob/c208e3a0760156b8a4cffe681daa31d0127a6ee7/vertx-lang-kotlin/pom.xml#L808-L817

So it is recommended to move the code to the src/main/java directory.

Tim-Britton commented 5 years ago

Directory src/main/kotlin will be removed by the clean task,

https://github.com/vert-x3/vertx-lang-kotlin/blob/c208e3a0760156b8a4cffe681daa31d0127a6ee7/vertx-lang-kotlin/pom.xml#L808-L817

So it is recommended to move the code to the src/main/java directory. @okou19900722

Maybe I'm not understanding but all the source files for this project are in src/man/kotlin am I messing something?

I've included what I'm seeing in intellij below:

image
okou19900722 commented 5 years ago

@Tim-Britton have you check the src/main/java yet? the extension function is generated to src/main/kotlin by vertx-codegen, so sometimes, If you execute mvn clean, directory src/main/kotlin will be removed

tsegismont commented 1 year ago

Superseded by #253