search

vert-x3 / vertx-lang-kotlin

Vert.x for Kotlin
Apache License 2.0
296 stars 68 forks source link

Add some possibly useful code ported from https://github.com/huanshankeji/kotlin-common/tree/main/vertx #222

Closed ShreckYe closed 1 year ago

ShreckYe commented 2 years ago

Motivation:

Hi, Vert.x Maintainers. We have been developing our projects in Kotlin with the Vert.x toolkit as the core of the backend. It's been quite smooth and this project provides a lot of useful extensions in Kotlin. During our development, we came up with a few more common extensions in our shared code repository, which we thought could be ported back to this project and made universally available.

We have tried to pick the less opinionated code from our common project in this PR so it's generally useful to most developers using Vert.x in Kotlin. If there is any code that is not appropriate to be added back to this repository, just feel free to remove it or make further changes as it suits your needs. Or if there is none to be added, just close this PR.

Thank you.

vietj commented 2 years ago

can you use vertx-unit instead of vertx-junit5 for the tests for the sake of consistency ?

ShreckYe commented 2 years ago

OK, I will try to adapt them.

ShreckYe commented 2 years ago

@vietj Hi Julien. It's done. Please review.

vietj commented 2 years ago

I pinged kotlin users on our discord to give eventually feedback on the PR

wowselim commented 2 years ago

There's some pretty neat additions proposed here that should help reduce boilerplate in most kotlin projects 👍

jojopad commented 2 years ago

Some updates with the documentation and code samples how to use the proposed new vertx kotlin extensions would be really helpful

ShreckYe commented 2 years ago

There's some pretty neat additions proposed here that should help reduce boilerplate in most kotlin projects +1

Thank you.

ShreckYe commented 2 years ago

I don't fully understand why the CI tests failed. Is it because that the "kotlin" source set in "vertx-lang-kotlin" is overriden by generated code?

vietj commented 2 years ago

do we have consensus on this PR ?

vietj commented 2 years ago

I don't know what is wrong with tests not passing, have you tried to build locally ?

ShreckYe commented 2 years ago

The Maven test phases pass locally. I moved Tuple.kt to the java source directory. Maybe this will work.

tsegismont commented 1 year ago

Superseded by https://github.com/vert-x3/vertx-lang-kotlin/pull/253