search

vert-x3 / vertx-lang-kotlin

Vert.x for Kotlin
Apache License 2.0
296 stars 68 forks source link

Upgrade to 4.4.0 requires stdlib #231

Closed hantsy closed 1 year ago

hantsy commented 1 year ago

When upgrading my sample from 4.3.8 to 4.4.0, I have to add kotlin-stdlib to make it work, https://github.com/hantsy/vertx-sandbox/blob/5d5a18a168d13701a36d703183787d0b3af85fcd/kotlin/pom.xml#L54

Is the kotlin-stdlib not a dep of verxt-lang-kotlin since 4.4.0?

tsegismont commented 1 year ago

@hantsy right, this is a consequence of #227

kotlin-stdlib is not strictly required by the project. I wonder if there's a reason why we should include it.

Any suggestion @AlexeySoshin ?

hantsy commented 1 year ago

No need kotlin-stdlib-jdk8, kotlin-stdlib-jdk7 etc., the kotlin-stdlib includes them.

vincentfree commented 1 year ago

For kotlin based projects it should at least be in with provided scope. A kotlin project can't function without it but this library doesn't need to set the library version since a typical project includes it.

tsegismont commented 1 year ago

I looked at one the POM files for Ktor (given it's similar in purpose):

https://search.maven.org/artifact/io.ktor/ktor-server-core-jvm/2.3.5/jar

They do bring the stdlib-jdk8 lib transitively.

So I'll update our project and bring the stdlib-jdk8 lib back

tsegismont commented 1 year ago

Fixed by 26bf045