search

vert-x3 / vertx-lang-ruby

Vert.x Ruby support
Apache License 2.0
14 stars 12 forks source link

Revert 3.4 change to ruby method names #31

Closed mmindenhall closed 7 years ago

mmindenhall commented 7 years ago

Per this discussion thread, ruby predicate method names were changed in version 3.4 to only end with a question mark if the method name begins with "is".

However, it is definitely idiomatic in ruby that all predicate method names should end with a question mark. This is true for core ruby (e.g., Object), the standard library, and 3rd party libraries/gems.

Please restore the idiomatic behavior in version 3.5.

tsegismont commented 7 years ago

Would you like to contribute the fix?

2017-09-08 18:27 GMT+02:00 Mark Mindenhall notifications@github.com:

Per this discussion thread https://groups.google.com/forum/#!topic/vertx/CdH7AZDLvR0, ruby predicate method names were changed in version 3.4 to only end with a question mark if the method name begins with "is".

However, it is definitely idiomatic in ruby that all predicate method names should end with a question mark. This is true for core ruby (e.g., Object https://ruby-doc.org/core-2.3.3/Object.html), the standard library, and 3rd party libraries/gems.

Please restore the idiomatic behavior in version 3.5.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-lang-ruby/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbltu0GrSPUsKompxMSQlu9089lFKy7ks5sgWsDgaJpZM4PRaKH .

mmindenhall commented 7 years ago

I looked around before filing the issue, but couldn't find the commit that changed the behavior. I don't think that code lives in this project. Any pointers?

tsegismont commented 7 years ago

I would expect the change to be needed in the templates for code generation.

2017-09-12 16:35 GMT+02:00 Mark Mindenhall notifications@github.com:

I looked around before filing the issue, but couldn't find the commit that changed the behavior. I don't think that code lives in this project. Any pointers?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-lang-ruby/issues/31#issuecomment-328872297, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbltqIazKBeNUzTbf0HlUnQzU3dXv84ks5shpa1gaJpZM4PRaKH .