search

vert-x3 / vertx-lang-ruby

Vert.x Ruby support
Apache License 2.0
14 stars 12 forks source link

Revert 3.4 change to ruby predicate method names (fixes #31) #32

Closed mmindenhall closed 7 years ago

mmindenhall commented 7 years ago

Submitting PR for this as requested. Thanks!

tsegismont commented 7 years ago

Thanks! Looks good to me. Can you please send an email to vertx-dev? This would be a breaking change so it should be advertised there.

mmindenhall commented 7 years ago

I've posted twice in the vertx-dev google group, but neither post has shown up in the list. Is there a moderator that needs to approve?

mmindenhall commented 7 years ago

@tsegismont, would you mind posting the following? I've tried posting to the vertx-dev google group twice, and both times it looks like the post succeeds, but then it never appears. This has happened to me before also on the vertx-user group...I post something and it never shows in the list. Is there a moderator rejecting these posts?

Subject: Proposed breaking change in 3.5 (vertx-lang-ruby) Hello,

In vert.x 3.4, there was a breaking change to ruby predicate method names (vertx-lang-ruby commit):

only append "?" if the method returns boolean and is prefixed by "is", e.g isComplete()

Although that was a breaking change, it somehow slipped through the cracks and was not called out in the 3.4 release notes.

It is idiomatic in ruby that all predicate method names should end with a question mark. This is true for core ruby (e.g., Object), the standard library, and 3rd party libraries/gems. For that reason, I filed an issue, which was followed up with a pull request. The change simply reverts the non-idiomatic predicate method names introduced in the 3.4 release. Since this is also a breaking change (against 3.4.x only), Thomas Segismont asked me to post here.

If the PR is accepted, this will need to be called out in the release notes for 3.5.

Thanks!

--Mark

tsegismont commented 7 years ago

Sure, will do.

2017-09-15 22:00 GMT+02:00 Mark Mindenhall notifications@github.com:

@tsegismont https://github.com/tsegismont, would you mind posting the following? I've tried posting to the vertx-dev google group twice, and both times it looks like the post succeeds, but then it never appears. This has happened to me before also on the vertx-user group...I post something and it never shows in the list. Is there a moderator rejecting these posts?

Subject: Proposed breaking change in 3.5 (vertx-lang-ruby) Hello,

In vert.x 3.4, there was a breaking change to ruby predicate method names (vertx-lang-ruby commit https://github.com/vert-x3/vertx-lang-ruby/commit/ff619130c3e7cc2abf6a528752056672b1c74191 ):

only append "?" if the method returns boolean and is prefixed by "is", e.g isComplete()

Although that was a breaking change, it somehow slipped through the cracks and was not called out in the 3.4 release notes.

It is idiomatic in ruby that all predicate method names should end with a question mark. This is true for core ruby (e.g., Object https://ruby-doc.org/core-2.3.3/Object.html), the standard library, and 3rd party libraries/gems. For that reason, I filed an issue https://github.com/vert-x3/vertx-lang-ruby/issues/31, which was followed up with a pull request https://github.com/vert-x3/vertx-lang-ruby/pull/32. The change simply reverts the non-idiomatic predicate method names introduced in the 3.4 release. Since this is also a breaking change (against 3.4.x only), Thomas Segismont asked me to post here.

If the PR is accepted, this will need to be called out in the release notes for 3.5.

Thanks!

--Mark

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-lang-ruby/pull/32#issuecomment-329887149, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbltiizMyO7eISIyu00wFCPOHK5XHE3ks5sitdSgaJpZM4PVFv_ .

tsegismont commented 7 years ago

@mmindenhall thank you!

tsegismont commented 7 years ago

I updated the 3.5 breaking changes page.

2017-09-16 13:56 GMT+02:00 Julien Ponge notifications@github.com:

@jponge approved this pull request.

Spot on

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-lang-ruby/pull/32#pullrequestreview-63201410, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbltjaf8IL61eLGdnY2ySYHoTBemv8eks5si7dogaJpZM4PVFv_ .