search

vert-x3 / vertx-maven-service-factory

Verticle factory for resolving verticles from Maven at run-time
Apache License 2.0
12 stars 12 forks source link

Use HTTPS by default #12

Closed meshuga closed 9 years ago

meshuga commented 9 years ago

Currently the default repositories (http://central.maven.org/maven2/ and http://oss.sonatype.org/content/repositories/snapshots/) use HTTP protocol. This PR updates the repositories to use HTTPS.

cescoffier commented 9 years ago

Makes sense for me.

Do you have signed the Eclipse CLA ?

meshuga commented 9 years ago

Yes, I have.

cescoffier commented 9 years ago

Thanks !

cescoffier commented 9 years ago

The switch to HTTPS is causing couple of SSL issue. Gonna revert the commit, and have a better look.

meshuga commented 9 years ago

Do you mean https://vertx.ci.cloudbees.com/view/vert.x-3/job/vert.x3-maven-service-factory/1725/ ? All of the tests are failing probably because of local copy of maven-metadata.xml of io.vertx:vertx-docgen:jar:3.0.0-SNAPSHOT.

cescoffier commented 9 years ago

Yes, something looks wrong with this artefact.

I've another computer with SSL certificate issues, because they are really old.

Will fix that tomorrow morning, but your commit is good, it our environment that need some cleanup / maintenance.

Sent from my iPhone

On 10 juin 2015, at 21:15, Patryk Orwat notifications@github.com wrote:

Do you mean https://vertx.ci.cloudbees.com/view/vert.x-3/job/vert.x3-maven-service-factory/1725/ ? All of the tests are failing probably because of local copy of maven-metadata.xml of io.vertx:vertx-docgen:jar:3.0.0-SNAPSHOT.

— Reply to this email directly or view it on GitHub https://github.com/vert-x3/vertx-maven-service-factory/pull/12#issuecomment-110883076 .

cescoffier commented 9 years ago

Your commit is back. Sorry for the delay.

meshuga commented 9 years ago

No problem. Thanks for the merge!