search

vert-x3 / vertx-maven-service-factory

Verticle factory for resolving verticles from Maven at run-time
Apache License 2.0
12 stars 12 forks source link

add profile to separate bundle version from light version #15

Closed PatrickSauts closed 9 years ago

PatrickSauts commented 9 years ago

mvn clean package -P bundle will generate a vertx-maven-service-factory-bundle-.jar file with dependencies packaged in the jar, and mvn clean package will generate a vertx-maven-service-factory-.jar file clean.

PatrickSauts commented 9 years ago

Hi,

I'm making two pull requests.

One to make both jar with an assembly and this one that uses profiles.

I prefer the assembly one which is more common.

The aim is to be able to use your verticle as a dependency where we can handle the dependencies versions. For example HttpClient is not on the same version in that module and in Vert.x core which caused us some trouble.

Thank you. Have a nice Day.

PatrickSauts commented 9 years ago

Not improving this one. https://github.com/vert-x3/vertx-maven-service-factory/pull/16 is best