add assembly file to separate bundle version from light version

vert-x3 / vertx-maven-service-factory

Verticle factory for resolving verticles from Maven at run-time

Apache License 2.0

12 stars 12 forks source link

add assembly file to separate bundle version from light version #16

Closed PatrickSauts closed 9 years ago

PatrickSauts commented 9 years ago

Allow to create a "light" version of vertx-maven-service-factory to be used as a normal dependency in a project embedding Vert.x

PatrickSauts commented 9 years ago

Is it better now ? Anything else to change ?

PatrickSauts commented 9 years ago

As written in the README Vert.x picks up VerticleFactory implementations from the classpath, so you just need to make sure theServiceVerticleFactory jar is on the classpath. So should vertx-service-factory also be excluded from the fat jar ?

cescoffier commented 9 years ago

After thinking about it a bit more, I think we should do the opposite:

keep the main artifact with the same content as the current one to avoid compatibility issues
provide a bare artifact without dependencies

In addition, the current artifact is made to bring all aether dependencies but not vert.x dependencies. It is intended to be used in vert.x distributions (providing the vert.x artifacts). So it should not include any vert.x artifacts.

cescoffier commented 9 years ago

@PatrickSauts can you check that https://github.com/vert-x3/vertx-maven-service-factory/commit/b30f2cfde42ca562a597622882a7333e516a199b provides the artifact you need ?