search

vert-x3 / vertx-maven-service-factory

Verticle factory for resolving verticles from Maven at run-time
Apache License 2.0
12 stars 12 forks source link

Error in documentation #22

Closed Xophe closed 8 years ago

Xophe commented 8 years ago

The docs says :

The service name (my-service) can be omitted when the META-INF/MANIFEST a the jar containing the service contains a Main-Verticle entry that declares the verticle to run:

vertx.deployVerticle("maven:com.mycompany:my-artifact:1.2::my-service", options); And the manifest contains: Main-Verticle: service:my.service

It should say :

The service name (my-service) can be omitted when the META-INF/MANIFEST in the jar containing the service contains a Main-Verticle entry that declares the verticle to run:

vertx.deployVerticle("maven:com.mycompany:my-artifact:1.2", options); and the manifest contains: Main-Verticle: service:my-service and the jar contains a my-service.json file.

I had to read the code to get it right. Works nicely one this clarified.

cescoffier commented 8 years ago

The fix should be soon available on the web site. Thanks for reporting the error !

Xophe commented 8 years ago

You're welcome. Except this little thing, it works great and is exactly what I need. Regards.

Le 11/02/2016 16:56, Clement Escoffier a écrit :

The fix should be soon available on the web site. Thanks for reporting the error !

— Reply to this email directly or view it on GitHub https://github.com/vert-x3/vertx-maven-service-factory/issues/22#issuecomment-182931234.