Determine and annotate mongo method that might return null so RxJava2 generates correct code

vert-x3 / vertx-mongo-client

Mongo Client for Eclipse Vert.x

http://vertx.io

Apache License 2.0

58 stars 98 forks source link

Determine and annotate mongo method that might return null so RxJava2 generates correct code #142

Closed gaol closed 5 years ago

gaol commented 6 years ago

RxJava 2 does not allow to emit null.

However, methods like:

Single<JsonObject> io.vertx.reactivex.ext.mongo.MongoClient.rxFindOne()
Single<JsonObject> io.vertx.reactivex.ext.mongo.MongoClient.rxFindOneAndUpdate()
some other methods too emit null if they don't find any document.

The return type as Maybe<JsonObject> should be more appropriate so that MaybeObserver.onComplete() method can be called in case of no document found.

Related issues:

vietj commented 6 years ago

I've made this issue more general purpose

vietj commented 6 years ago

@karianna is it an issue you can take care off ? it's not long but requires to know well the current API

karianna commented 6 years ago

I'll take a look and @johnoliver can make sure I don't do anything insane :-)

vietj commented 6 years ago

thanks much appreciated

cazacugmihai commented 5 years ago

Is there any progress on this?

karianna commented 5 years ago

Unfortunately not - this is quite far down our priority list at the moment

tsegismont commented 5 years ago

@karianna @cazacugmihai I've submitted #194

This issue has been filed some time ago and meanwhile quite a few methods have been fixed already (see for example https://github.com/vert-x3/vertx-mongo-client/pull/166).

I believe we could change the milestone to 3.8.0 (cc @vietj ). In this case I'll update the breaking changes page.

karianna commented 5 years ago

Is the 'master; branch 3.8.0 or 4.0.0?

tsegismont commented 5 years ago

@karianna master is 4.0. If we change the target milestone I'll cherry-pick to the 3.8 branch.

karianna commented 5 years ago

Cool, It's not an issue for us personally but if you want it for 3.8.0 then I'm happy to move the milestone!

tsegismont commented 5 years ago

@karianna yes please, move it to 3.8.0. Any chance that you could review the PR this week?

karianna commented 5 years ago

Added new milestone

karianna commented 5 years ago

@tsegismont Can you also submit a backport PR to the correct branch (I think it's 3.7.x)?

tsegismont commented 5 years ago

@karianna actually it's 3.8 but if we do a 3.7.2 I'll backport the commit there too.

karianna commented 5 years ago

3.8 is fine in that case :-)