search

vert-x3 / vertx-mongo-client

Mongo Client for Eclipse Vert.x
http://vertx.io
Apache License 2.0
58 stars 98 forks source link

bump MongoDB version to 4.2.1 (#253) and added support for updates with aggregation pipelines (#236) #254

Closed bfreuden closed 3 years ago

bfreuden commented 3 years ago

First proposal for issue/enhancement #236. Second tentative since PR #251 has validation issues. If successful, this PR replaces PR #251.

bfreuden commented 3 years ago

@vietj thank you for the review! I have pushed a commit with javadoc changes you mentioned (and others as well).

bfreuden commented 3 years ago

@vietj If you had a little time to review my changes, that would be great :+1:. Otherwise no worries.

bfreuden commented 3 years ago

Hi all, I'm very sorry to write this message. I hope it won't bother you. Is there anything I have to do? Should I worry about something?

vietj commented 3 years ago

sorry, the GitHub UI was still showing the previous result (it's an old tab), I just added comment for a last @code with MongoClientUpdateResult (or @link as you whish)

bfreuden commented 3 years ago

No problem! It's done: {@code MongoClientUpdateResult} I also corrected a few missing {@code MongoClientDeleteResult}

vietj commented 3 years ago

thanks for the contribution

bfreuden commented 3 years ago

Thanks for your perseverance